Bookmarks sidebar: "Open All in Tabs" not available on single-item folders #1701

Closed
opened 3 years ago by vlakoff · 6 comments
vlakoff commented 3 years ago (Migrated from github.com)

In my Bookmarks sidebar, I'm very used to right-click on folders and do "Open All in Tabs".

I just discovered that if the folder contains only one bookmark, the command is greyed out…

For convenience and consistency, I think the command should be available exactly the same.

In my Bookmarks sidebar, I'm very used to right-click on folders and do "Open All in Tabs". I just discovered that if the folder contains only one bookmark, the command is greyed out… For convenience and [consistency](https://en.wikipedia.org/wiki/Principle_of_least_astonishment), I think the command should be available exactly the same.
wolfbeast commented 3 years ago (Migrated from github.com)

I disagree. An active "open all" command does not make sense if there are no items or there is only one item to open. Pulling in POLA is really not relevant as there are no unexpected behaviors resulting from user action here.

I disagree. An active "open all" command does not make sense if there are no items or there is only one item to open. Pulling in POLA is really not relevant as there are no unexpected behaviors resulting from user action here.
vlakoff commented 3 years ago (Migrated from github.com)

I'm very used to this command "Open All in Tabs". That's how I open my bookmarks almost every time (and that happens a lot), after I have grouped them into folders.

So, I use the command by "muscle memory". But when the command is disabled, it completely breaks my workflow, it stops me and I have to think "ah, yes, here I can't use it", then open the folder, then middle-click on the bookmark…

I'm very used to this command "Open All in Tabs". That's how I open my bookmarks almost every time (and that happens a lot), after I have grouped them into folders. So, I use the command by "muscle memory". But when the command is disabled, it completely breaks my workflow, it stops me and I have to think "ah, yes, here I can't use it", then open the folder, then middle-click on the bookmark…
vlakoff commented 3 years ago (Migrated from github.com)

Actually, most often I don't do "right click > Open All in Tabs"… I directly middle-click on the folder.

Actually, most often I don't do "right click > Open All in Tabs"… I directly middle-click on the folder.
wolfbeast commented 3 years ago (Migrated from github.com)

Since middle-clicking means "Open the selected item(s) in a new tab/new tabs", it would make sense for the shortcut to extend to folders where they only have one item.

This would probably mean we have to split up the logic to make this happen depending on the caller.

Since middle-clicking means "Open the selected item(s) in a new tab/new tabs", it would make sense for the shortcut to extend to folders where they only have one item. This would probably mean we have to split up the logic to make this happen depending on the caller.
wolfbeast commented 3 years ago (Migrated from github.com)

This needs to be moved to the Pale Moon repo since it's front-end work.

This needs to be moved to the Pale Moon repo since it's front-end work.

This is already the default behavior in Basilisk and making this the same with Pale Moon involves changing the calls to the PlacesUtils.hasChildURIs function to not pass a true value to the aMultiple parameter in the following scripts:

/palemoon/components/places/content/controller.js, line 636:

if (!PlacesUtils.hasChildURIs(containerToUse)) {

/palemoon/components/places/content/sidebarUtils.js, line 39

PlacesUtils.hasChildURIs(tbo.view.nodeForTreeIndex(cell.row));
This is already the default behavior in Basilisk and making this the same with Pale Moon involves changing the calls to the `PlacesUtils.hasChildURIs` function to not pass a `true` value to the `aMultiple` parameter in the following scripts: `/palemoon/components/places/content/controller.js`, [line 636](http://xref.palemoon.org/moonchild-central/source/palemoon/components/places/content/controller.js#636): ```js if (!PlacesUtils.hasChildURIs(containerToUse)) { ``` `/palemoon/components/places/content/sidebarUtils.js`, [line 39](http://xref.palemoon.org/moonchild-central/source/palemoon/components/places/content/sidebarUtils.js#39) ```js PlacesUtils.hasChildURIs(tbo.view.nodeForTreeIndex(cell.row)); ```
Moonchild closed this issue 2 years ago
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: MoonchildProductions/Pale-Moon#1701
Loading…
There is no content yet.