MoonchildProductions
/
Pale-Moon
15
14
Fork 12
Code Issues 9 Pull Requests Releases 69 Activity
Labels Milestones
New Issue

Bookmark star not refreshed on address bar input cancellation #1897

Open
opened 4 months ago by Moonchild · 3 comments
Moonchild commented 4 months ago
Owner

When input to the address bar is cancelled, the bookmarks star state isn't refreshed to reflect the current page's bokmarked state, potentially leading to confusion.

How to reproduce:

  1. Navigate to a page that is bookmarked in the browser. In the address bar, there is a yellow star.
  2. In the address bar, type anything so that the URL is replaced with the suggestions drowndown.
  3. Press Escape once or twice, so that the suggestions are closed and the current page URL is displayed again.

Expected behavior
The bookmark star is yellow, i.e. reflecting the URL's bookmarked state.

Actual behavior
An empty star is displayed in the URL bar, instead of the expected yellow star.

Note this erroneous empty star has the behaviour of the yellow star, i.e. clicking on it shows the "edit this bookmark" tooltip. So it's a display-only issue where the star icon isn't refreshed properly.

When input to the address bar is cancelled, the bookmarks star state isn't refreshed to reflect the current page's bokmarked state, potentially leading to confusion. **How to reproduce:** 1. Navigate to a page that is bookmarked in the browser. In the address bar, there is a yellow star. 2. In the address bar, type anything so that the URL is replaced with the suggestions drowndown. 3. Press Escape once or twice, so that the suggestions are closed and the current page URL is displayed again. **Expected behavior** The bookmark star is yellow, i.e. reflecting the URL's bookmarked state. **Actual behavior** An empty star is displayed in the URL bar, instead of the expected yellow star. Note this erroneous empty star has the behaviour of the yellow star, i.e. clicking on it shows the "edit this bookmark" tooltip. So it's a display-only issue where the star icon isn't refreshed properly.
Moonchild added the Bug Good first issue Theme/UI labels 4 months ago
BenFenner commented 4 months ago

First reported on the forum:
https://forum.palemoon.org/viewtopic.php?f=5&t=29156
https://forum.palemoon.org/viewtopic.php?f=5&t=24643

I will see if I can tackle this as my second issue.

I guess I'll have to turn on browsing history and the suggestions drop-down, as both have long been disabled in my profiles. ;)
Edit: Ehhh, that's not working. I'll try to reproduce with PM portable on a Windows machine.
Edit 2: Yep, confirmed issue myself. We'll see how far I can get without having to build the app myself. :D

If anyone else is keen on taking this issue, you're welcome to as it may take me more time than someone else. Just let me know.

First reported on the forum: https://forum.palemoon.org/viewtopic.php?f=5&t=29156 https://forum.palemoon.org/viewtopic.php?f=5&t=24643 I will see if I can tackle this as my second issue. I guess I'll have to turn on browsing history and the suggestions drop-down, as both have long been disabled in my profiles. ;) Edit: Ehhh, that's not working. I'll try to reproduce with PM portable on a Windows machine. Edit 2: Yep, confirmed issue myself. We'll see how far I can get without having to build the app myself. :D If anyone else is keen on taking this issue, you're welcome to as it may take me more time than someone else. Just let me know.
BenFenner commented 4 months ago

For my own info in the future, I wanted the Browser Toolbox and here's how I got it:
https://forum.palemoon.org/viewtopic.php?f=46&t=29052&p=233691&hilit=Browser+Toolbox#p233691

Which helped me find the details of the favorite star to get me startet searching the codebase:

<image xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" id="star-button" class="urlbar-icon" onclick="BookmarkingUI.onCommand(event);" tooltiptext="Bookmark this page"/>

And it seems I will have to build from source on Linux Mint, so I made a thread with that info:
https://forum.palemoon.org/viewtopic.php?f=3&t=29157

For my own info in the future, I wanted the Browser Toolbox and here's how I got it: https://forum.palemoon.org/viewtopic.php?f=46&t=29052&p=233691&hilit=Browser+Toolbox#p233691 Which helped me find the details of the favorite star to get me startet searching the codebase: ```HTML <image xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" id="star-button" class="urlbar-icon" onclick="BookmarkingUI.onCommand(event);" tooltiptext="Bookmark this page"/> ``` And it seems I will have to build from source on Linux Mint, so I made a thread with that info: https://forum.palemoon.org/viewtopic.php?f=3&t=29157
Moonchild commented 4 months ago
Poster
Owner

Off-topic:
For future reference, please try not to use issues on the repo as a whiteboard or repurposing posts you make with extensive edits. People with repo tracking on will get a copy of every new reply post in e-mail, and it causes a lot of clutter with irrelevant posts ;-) -- the forum is indeed better suited for general banter or trying to figure out specific build requirements.

Off-topic: For future reference, please try not to use issues on the repo as a whiteboard or repurposing posts you make with extensive edits. People with repo tracking on will get a copy of every new reply post in e-mail, and it causes a lot of clutter with irrelevant posts ;-) -- the forum is indeed better suited for general banter or trying to figure out specific build requirements.
👍 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
release
master
theme-hidpi
27.9_RelBranch
27.8_RelBranch
27.7_RelBranch
27.6_RelBranch
27.5_RelBranch
27.4_RelBranch
27.3_RelBranch
27.2_RelBranch
27.1_RelBranch
27.0_RelBranch
26.5_Atom_RelBranch
Atom
26.5_RelBranch
v26_Dev
v25-LTS
26.4_Atom_RelBranch
26.4_RelBranch
26.3_Atom_RelBranch
26.3_RelBranch
26.2_Atom_RelBranch
26.2_RelBranch
26.1_Atom_RelBranch
26.1_RelBranch
26.0_Atom_RelBranch
26.0_RelBranch
25.8_Atom_Relbranch
25.8_RelBranch
v25_Atom
v25_Dev
25.7_Atom_Relbranch
25.7_RelBranch
25.6_Atom_RelBranch
25.6_RelBranch
25.5_Atom_RelBranch
25.5_RelBranch
25.4_Atom_RelBranch
25.4_RelBranch
25.3_RelBranch
25.3_Atom_RelBranch
25.2_Atom_RelBranch
25.2_RelBranch
25.1_RelBranch
25.1_Atom_RelBranch
25.0_Atom_RelBranch
25.0_RelBranch
24.7_RelBranch
24.6_RelBranch
Labels
Apply labels
Clear labels
Assigned Backed Out Bounty Bounty Paid Browser-Parity Bug Build Bustage Build System Code Cleanup Crash Critical Devtools Documentation Duplicate Enhancement Extensions Fixed Good first issue
Good issue for contributors new to the project Help Wanted High Risk Patch Images Incomplete Invalid Leave Open Legal Locale Media More Info Needed Mozregression Wanted On Hold OS: Linux OS: Mac OS X OS: Other OS: Windows Performance Places
Bookmarks/History Plugins Privacy Question Redirected to forum Regression Release Engineering Security SSUAO
Site-Specific User Agent Overrides String changes Sync Tabbed browsing
Tab handling and switching Theme changes Theme/UI Unconfirmed Uplift Wanted Verification Needed Verified Wontfix Works For Me
No Label Assigned Backed Out Bounty Bounty Paid Browser-Parity Bug Build Bustage Build System Code Cleanup Crash Critical Devtools Documentation Duplicate Enhancement Extensions Fixed Good first issue Help Wanted High Risk Patch Images Incomplete Invalid Leave Open Legal Locale Media More Info Needed Mozregression Wanted On Hold OS: Linux OS: Mac OS X OS: Other OS: Windows Performance Places Plugins Privacy Question Redirected to forum Regression Release Engineering Security SSUAO String changes Sync Tabbed browsing Theme changes Theme/UI Unconfirmed Uplift Wanted Verification Needed Verified Wontfix Works For Me
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MoonchildProductions/Pale-Moon#1897
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes