Closing browser with GCLI open removes GCLI feature #545

Closed
opened 7 years ago by Lootyhoof · 4 comments
Lootyhoof commented 7 years ago (Migrated from github.com)

If the GCLI (command-line; shift+F2) tool is open while the browser is closing, it will prevent the GCLI from opening again upon restart of the browser. Viewing the relevant entry in the Web Developer menu (Web Developer - Developer tools) reports that the feature is currently enabled, however attempting to open via this menu entry or via the keyboard shortcut does nothing.

This is specific to Tycho's devtools, as of 27.0.0b1.

If the GCLI (command-line; shift+F2) tool is open while the browser is closing, it will prevent the GCLI from opening again upon restart of the browser. Viewing the relevant entry in the Web Developer menu (Web Developer - Developer tools) reports that the feature is currently enabled, however attempting to open via this menu entry or via the keyboard shortcut does nothing. This is specific to Tycho's devtools, as of 27.0.0b1.
mattatobin commented 7 years ago (Migrated from github.com)

Please try this in b2.. Also, please take note of anything from the Toolkit Error Console.

Please try this in b2.. Also, please take note of anything from the Toolkit Error Console.
janekptacijarabaci commented 7 years ago (Migrated from github.com)

Throws an error in Browser Console:

TypeError: TargetFactory is undefined
Stack trace:
.get@resource://app/modules/devtools/DeveloperToolbar.jsm:299:5
CommandUtils.createEnvironment@resource://app/modules/devtools/DeveloperToolbar.jsm:196:9
DeveloperToolbar.prototype.show/this._showPromise</</<@resource://app/modules/devtools/DeveloperToolbar.jsm:421:24
resolve@resource://gre/modules/jetpack/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40
then@resource://gre/modules/jetpack/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43
resolve@resource://gre/modules/jetpack/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:72:11
resolve@resource://gre/modules/jetpack/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:11
resolve@resource://gre/modules/jetpack/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40
then@resource://gre/modules/jetpack/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43
resolve@resource://gre/modules/jetpack/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:72:11
resolve@resource://gre/modules/jetpack/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:11
resolve@resource://gre/modules/jetpack/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40
then@resource://gre/modules/jetpack/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43
resolve@resource://gre/modules/jetpack/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:72:11
resolve@resource://gre/modules/jetpack/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:11
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:867:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:746:7
this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:688:37
Promise-backend.js:870

=>
https://github.com/MoonchildProductions/Pale-Moon/blob/27.0.0b2/browser/devtools/shared/DeveloperToolbar.jsm#L299

Throws an error in Browser Console: ``` TypeError: TargetFactory is undefined Stack trace: .get@resource://app/modules/devtools/DeveloperToolbar.jsm:299:5 CommandUtils.createEnvironment@resource://app/modules/devtools/DeveloperToolbar.jsm:196:9 DeveloperToolbar.prototype.show/this._showPromise</</<@resource://app/modules/devtools/DeveloperToolbar.jsm:421:24 resolve@resource://gre/modules/jetpack/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40 then@resource://gre/modules/jetpack/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43 resolve@resource://gre/modules/jetpack/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:72:11 resolve@resource://gre/modules/jetpack/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:11 resolve@resource://gre/modules/jetpack/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40 then@resource://gre/modules/jetpack/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43 resolve@resource://gre/modules/jetpack/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:72:11 resolve@resource://gre/modules/jetpack/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:11 resolve@resource://gre/modules/jetpack/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40 then@resource://gre/modules/jetpack/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43 resolve@resource://gre/modules/jetpack/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:72:11 resolve@resource://gre/modules/jetpack/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:11 Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:867:23 this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:746:7 this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:688:37 Promise-backend.js:870 ``` => https://github.com/MoonchildProductions/Pale-Moon/blob/27.0.0b2/browser/devtools/shared/DeveloperToolbar.jsm#L299
wolfbeast commented 7 years ago (Migrated from github.com)

I'll roll the relevant PR into beta 3, see if that fixes it.

(Of course you'll have to build your own with devtools enabled to check)

I'll roll the relevant PR into beta 3, see if that fixes it. (Of course you'll have to build your own with devtools enabled to check)
wolfbeast commented 7 years ago (Migrated from github.com)

I've spun up a trunk build with devtools and this seems to be fixed now.

I've spun up a trunk build with devtools and this seems to be fixed now.
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: MoonchildProductions/Pale-Moon#545
Loading…
There is no content yet.