OS X: Personas kill the titlebar #623

Closed
opened 7 years ago by Lootyhoof · 4 comments
Lootyhoof commented 7 years ago (Migrated from github.com)

On OS X (using Tycho) it would appear that using a persona kills the titlebar, including caption buttons.

OS X

This appears to be due to 625989 (with additional back-end work having been already done in multiple dependant bugs), however applying this doesn't seem to restore the caption buttons (and in fact kills them entirely). I'm not sure where caption button-specific work lives regarding the required bugs, unfortunately (though some of the dependant bugs on this one look promising).

I'm afraid someone more familiar to OS X may need to look into this one.

On OS X (using Tycho) it would appear that using a persona kills the titlebar, including caption buttons. ![OS X](http://i.imgur.com/xnqsAen.png) This _appears_ to be due to [625989](https://bugzilla.mozilla.org/show_bug.cgi?id=625989) (with additional back-end work having been already done in multiple dependant bugs), however applying this doesn't seem to restore the caption buttons (and in fact kills them entirely). I'm not sure where caption button-specific work lives regarding the required bugs, unfortunately (though some of the dependant bugs on this one look promising). I'm afraid someone more familiar to OS X may need to look into this one.
wolfbeast commented 7 years ago (Migrated from github.com)

Caption button specific code lives in /widget in the source tree, split up per OS.

Caption button specific code lives in `/widget` in the source tree, split up per OS.
graciecat commented 6 years ago (Migrated from github.com)

Confirmed that this is still an issue in PM 27.6.2 unofficial build for Mac OS

Confirmed that this is still an issue in PM 27.6.2 unofficial build for Mac OS
wolfbeast commented 5 years ago (Migrated from github.com)

Is this still an issue in PM 28.0.0 prereleases, if Mac builds are available?

Is this still an issue in PM 28.0.0 prereleases, if Mac builds are available?
SpockFan02 commented 5 years ago (Migrated from github.com)

Yes.
screenshot 2018-06-12 18 43 56
I'm sorry I didn't get back on this earlier, I've been doing other things and couldn't install any "themes" from AMO at first.
FYI: The (Pale Moon) at the end of the default AMO UA override needs to be removed, otherwise personas are uninstallable (it just tells you to download Firefox).

Yes. <img width="1440" alt="screenshot 2018-06-12 18 43 56" src="https://user-images.githubusercontent.com/11634417/41326217-ddd08786-6e72-11e8-963f-e5890ae1a1fe.png"> I'm sorry I didn't get back on this earlier, I've been doing other things and couldn't install any "themes" from AMO at first. FYI: The `(Pale Moon)` at the end of the default AMO UA override needs to be removed, otherwise personas are uninstallable (it just tells you to download Firefox).
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: MoonchildProductions/Pale-Moon#623
Loading…
There is no content yet.