Finder failure when tabs get unloaded. #944

The finder may intermittently still fail, when tabs are unloaded/suspended. It seems to happen when there was a previous search and the document searched has been in a suspended state.
The finder will fail on that tab going forward until the tab is closed/reopened (e.g. using undo close).

Errors:

[Exception... "Component returned failure code: 0x80004002 (NS_NOINTERFACE) [nsIInterfaceRequestor.getInterface]"  nsresult: "0x80004002 (NS_NOINTERFACE)"  location: "JS frame :: resource://gre/modules/Finder.jsm :: Finder.prototype._getWindow :: line 505"  data: no] Finder.jsm:507:0
TypeError: this._getWindow(...) is undefined Finder.jsm:182:4

code:

  _getWindow: function () {
    try {
      return this._docShell.QueryInterface(Ci.nsIInterfaceRequestor).getInterface(Ci.nsIDOMWindow);
    } catch(e) {
      Cu.reportError(e);
    }
  },

After this call fails, the finder breaks because aWindow will be null.
We may have lost our docshell along the way; might have to re-fetch it?

The finder may intermittently still fail, when tabs are unloaded/suspended. It seems to happen when there was a previous search and the document searched has been in a suspended state. The finder will fail on that tab going forward until the tab is closed/reopened (e.g. using undo close). Errors: ```` [Exception... "Component returned failure code: 0x80004002 (NS_NOINTERFACE) [nsIInterfaceRequestor.getInterface]" nsresult: "0x80004002 (NS_NOINTERFACE)" location: "JS frame :: resource://gre/modules/Finder.jsm :: Finder.prototype._getWindow :: line 505" data: no] Finder.jsm:507:0 TypeError: this._getWindow(...) is undefined Finder.jsm:182:4 ```` code: ````javascript _getWindow: function () { try { return this._docShell.QueryInterface(Ci.nsIInterfaceRequestor).getInterface(Ci.nsIDOMWindow); } catch(e) { Cu.reportError(e); } }, ```` After this call fails, the finder breaks because aWindow will be null. We may have lost our docshell along the way; might have to re-fetch it?

Reported 2 months ago to Firefox; no movement there.
https://bugzilla.mozilla.org/show_bug.cgi?id=1328092

Reported 2 months ago to Firefox; no movement there. https://bugzilla.mozilla.org/show_bug.cgi?id=1328092

Finder issues can (and have been) fixed in the unloading extension (alternative created to BarTab), meaning this is no longer applicable.

Labels Milestones

Finder failure when tabs get unloaded. #944