MoonchildProductions
/
UXP
10
6
Fork 8
Code Issues 97 Pull Requests 0 Releases 90 Activity
Labels Milestones
New Issue

#1195 Crash in AutoSuppressGC (cx is null)

Closed
opened 1 year ago by wolfbeast · 2 comments
wolfbeast commented 1 year ago (Migrated from github.com)

As reported on the forum: https://forum.palemoon.org/viewtopic.php?f=46&t=16081&p=171491#p171488

Fallout from #1192

This crashes in jsgc.cpp line 6310

AutoSuppressGC::AutoSuppressGC(ExclusiveContext* cx)
  : suppressGC_(cx->perThreadData->suppressGC) <== crash point
{
    suppressGC_++;
}

cx=<NULL>
Looks like it’s trying to report an error in code, but the JS context for it has been GCed out from under it before the GC suppressor had a chance to prevent it. Possibly because you go from ExclusiveContext (addNoteASCII) to JSContext (CreateErrorNoteVA) and back (subsequent calls)?

Pretty long call stack:

>	xul.dll!js::gc::AutoSuppressGC::AutoSuppressGC(js::ExclusiveContext * cx) Line 6311	C++
 	xul.dll!ExpandErrorArgumentsHelper<JSErrorNotes::Note>(js::ExclusiveContext * cx, const JSErrorFormatString *(*)(void *, const unsigned int) callback, void * userRef, const unsigned int errorNumber, const char16_t * * messageArgs, js::ErrorArgumentsType argumentsType, JSErrorNotes::Note * reportp, char * ap) Line 651	C++
 	xul.dll!CreateErrorNoteVA(JSContext * cx, const char * filename, unsigned int lineno, unsigned int column, const JSErrorFormatString *(*)(void *, const unsigned int) errorCallback, void * userRef, const unsigned int errorNumber, js::ErrorArgumentsType argumentsType, char * ap) Line 6344	C++
 	xul.dll!JSErrorNotes::addNoteASCII(js::ExclusiveContext * cx, const char * filename, unsigned int lineno, unsigned int column, const JSErrorFormatString *(*)(void *, const unsigned int) errorCallback, void * userRef, const unsigned int errorNumber, ...) Line 6364	C++
 	xul.dll!js::frontend::Parser<js::frontend::SyntaxParseHandler>::reportMissingClosing(unsigned int errorNumber, unsigned int noteNumber, unsigned int openedPos) Line 1049	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::arrayInitializer(js::frontend::YieldHandling yieldHandling, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError) Line 9467	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::primaryExpr(js::frontend::YieldHandling yieldHandling, js::frontend::TripledotHandling tripledotHandling, js::frontend::TokenKind tt, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError, js::frontend::ParserBase::InvokedPrediction invoked) Line 10190	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::memberExpr(js::frontend::YieldHandling yieldHandling, js::frontend::TripledotHandling tripledotHandling, js::frontend::TokenKind tt, bool allowCallSyntax, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError, js::frontend::ParserBase::InvokedPrediction invoked) Line 8933	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::unaryExpr(js::frontend::YieldHandling yieldHandling, js::frontend::TripledotHandling tripledotHandling, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError, js::frontend::ParserBase::InvokedPrediction invoked) Line 8464	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::assignExpr(js::frontend::InHandling inHandling, js::frontend::YieldHandling yieldHandling, js::frontend::TripledotHandling tripledotHandling, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError, js::frontend::ParserBase::InvokedPrediction invoked) Line 8139	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::initializerInNameDeclaration(js::frontend::ParseNode * decl, js::frontend::ParseNode * binding, JS::Handle<js::PropertyName *> name, js::frontend::DeclarationKind declKind, bool initialDeclaration, js::frontend::YieldHandling yieldHandling, js::frontend::ParseNodeKind * forHeadKind, js::frontend::ParseNode * * forInOrOfExpression) Line 4716	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::declarationName(js::frontend::ParseNode * decl, js::frontend::DeclarationKind declKind, js::frontend::TokenKind tt, bool initialDeclaration, js::frontend::YieldHandling yieldHandling, js::frontend::ParseNodeKind * forHeadKind, js::frontend::ParseNode * * forInOrOfExpression) Line 4822	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::declarationList(js::frontend::YieldHandling yieldHandling, js::frontend::ParseNodeKind kind, js::frontend::ParseNodeKind * forHeadKind, js::frontend::ParseNode * * forInOrOfExpression) Line 4912	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::statementListItem(js::frontend::YieldHandling yieldHandling, bool canHaveDirectives) Line 7654	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::statementList(js::frontend::YieldHandling yieldHandling) Line 4074	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::functionBody(js::frontend::InHandling inHandling, js::frontend::YieldHandling yieldHandling, js::frontend::FunctionSyntaxKind kind, js::frontend::Parser<js::frontend::FullParseHandler>::FunctionBodyType type) Line 2657	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::functionFormalParametersAndBody(js::frontend::InHandling inHandling, js::frontend::YieldHandling yieldHandling, js::frontend::ParseNode * pn, js::frontend::FunctionSyntaxKind kind, mozilla::Maybe<unsigned int> parameterListEnd, bool isStandaloneFunction) Line 3702	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::innerFunction(js::frontend::ParseNode * pn, js::frontend::ParseContext * outerpc, js::frontend::FunctionBox * funbox, unsigned int toStringStart, js::frontend::InHandling inHandling, js::frontend::YieldHandling yieldHandling, js::frontend::FunctionSyntaxKind kind, js::frontend::Directives inheritedDirectives, js::frontend::Directives * newDirectives) Line 3503	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::trySyntaxParseInnerFunction(js::frontend::ParseNode * pn, JS::Handle<JSFunction *> fun, unsigned int toStringStart, js::frontend::InHandling inHandling, js::frontend::YieldHandling yieldHandling, js::frontend::FunctionSyntaxKind kind, js::GeneratorKind generatorKind, js::FunctionAsyncKind asyncKind, bool tryAnnexB, js::frontend::Directives inheritedDirectives, js::frontend::Directives * newDirectives) Line 3463	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::functionDefinition(unsigned int toStringStart, js::frontend::ParseNode * pn, js::frontend::InHandling inHandling, js::frontend::YieldHandling yieldHandling, JS::Handle<JSAtom *> funName, js::frontend::FunctionSyntaxKind kind, js::GeneratorKind generatorKind, js::FunctionAsyncKind asyncKind, bool tryAnnexB) Line 3366	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::functionExpr(unsigned int toStringStart, js::frontend::ParserBase::InvokedPrediction invoked, js::FunctionAsyncKind asyncKind) Line 3890	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::primaryExpr(js::frontend::YieldHandling yieldHandling, js::frontend::TripledotHandling tripledotHandling, js::frontend::TokenKind tt, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError, js::frontend::ParserBase::InvokedPrediction invoked) Line 10190	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::memberExpr(js::frontend::YieldHandling yieldHandling, js::frontend::TripledotHandling tripledotHandling, js::frontend::TokenKind tt, bool allowCallSyntax, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError, js::frontend::ParserBase::InvokedPrediction invoked) Line 8933	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::unaryExpr(js::frontend::YieldHandling yieldHandling, js::frontend::TripledotHandling tripledotHandling, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError, js::frontend::ParserBase::InvokedPrediction invoked) Line 8464	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::assignExpr(js::frontend::InHandling inHandling, js::frontend::YieldHandling yieldHandling, js::frontend::TripledotHandling tripledotHandling, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError, js::frontend::ParserBase::InvokedPrediction invoked) Line 8139	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::objectLiteral(js::frontend::YieldHandling yieldHandling, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError) Line 9750	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::primaryExpr(js::frontend::YieldHandling yieldHandling, js::frontend::TripledotHandling tripledotHandling, js::frontend::TokenKind tt, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError, js::frontend::ParserBase::InvokedPrediction invoked) Line 10190	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::memberExpr(js::frontend::YieldHandling yieldHandling, js::frontend::TripledotHandling tripledotHandling, js::frontend::TokenKind tt, bool allowCallSyntax, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError, js::frontend::ParserBase::InvokedPrediction invoked) Line 8933	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::unaryExpr(js::frontend::YieldHandling yieldHandling, js::frontend::TripledotHandling tripledotHandling, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError, js::frontend::ParserBase::InvokedPrediction invoked) Line 8464	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::assignExpr(js::frontend::InHandling inHandling, js::frontend::YieldHandling yieldHandling, js::frontend::TripledotHandling tripledotHandling, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError, js::frontend::ParserBase::InvokedPrediction invoked) Line 8139	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::initializerInNameDeclaration(js::frontend::ParseNode * decl, js::frontend::ParseNode * binding, JS::Handle<js::PropertyName *> name, js::frontend::DeclarationKind declKind, bool initialDeclaration, js::frontend::YieldHandling yieldHandling, js::frontend::ParseNodeKind * forHeadKind, js::frontend::ParseNode * * forInOrOfExpression) Line 4716	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::declarationName(js::frontend::ParseNode * decl, js::frontend::DeclarationKind declKind, js::frontend::TokenKind tt, bool initialDeclaration, js::frontend::YieldHandling yieldHandling, js::frontend::ParseNodeKind * forHeadKind, js::frontend::ParseNode * * forInOrOfExpression) Line 4822	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::declarationList(js::frontend::YieldHandling yieldHandling, js::frontend::ParseNodeKind kind, js::frontend::ParseNodeKind * forHeadKind, js::frontend::ParseNode * * forInOrOfExpression) Line 4912	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::variableStatement(js::frontend::YieldHandling yieldHandling) Line 7377	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::statementListItem(js::frontend::YieldHandling yieldHandling, bool canHaveDirectives) Line 7603	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::statementList(js::frontend::YieldHandling yieldHandling) Line 4074	C++
 	xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::globalBody(js::frontend::GlobalSharedContext * globalsc) Line 2180	C++
 	xul.dll!BytecodeCompiler::compileScript(JS::Handle<JSObject *> environment, js::frontend::SharedContext * sc) Line 341	C++
 	xul.dll!js::frontend::CompileGlobalScript(js::ExclusiveContext * cx, js::LifoAlloc & alloc, js::ScopeKind scopeKind, const JS::ReadOnlyCompileOptions & options, JS::SourceBufferHolder & srcBuf, js::SourceCompressionTask * extraSct, js::ScriptSourceObject * * sourceObjectOut) Line 577	C++
 	xul.dll!js::ScriptParseTask::parse() Line 370	C++
 	xul.dll!js::HelperThread::handleParseWorkload(js::AutoLockHelperThreadState & locked, unsigned int stackLimit) Line 1629	C++
 	xul.dll!js::HelperThread::threadLoop() Line 1883	C++
 	xul.dll!js::detail::ThreadTrampoline<void (__cdecl&)(void *),js::HelperThread *>::Start(void * aPack) Line 228	C++
 	ucrtbase.dll!__crt_at_quick_exit()	Unknown
 	kernel32.dll!@BaseThreadInitThunk@12()	Unknown
 	ntdll.dll!___RtlUserThreadStart@8()	Unknown
 	ntdll.dll!__RtlUserThreadStart@8()	Unknown

@g4jc can you have a look at this please? Seems we lost the exclusive context in the parser chain somewhere in this call stack.

As reported on the forum: https://forum.palemoon.org/viewtopic.php?f=46&t=16081&p=171491#p171488 Fallout from #1192 This crashes in `jsgc.cpp` line 6310 ```C++ AutoSuppressGC::AutoSuppressGC(ExclusiveContext* cx) : suppressGC_(cx->perThreadData->suppressGC) <== crash point { suppressGC_++; } ``` `cx=<NULL>` Looks like it's trying to report an error in code, but the JS context for it has been GCed out from under it before the GC suppressor had a chance to prevent it. Possibly because you go from `ExclusiveContext` (`addNoteASCII`) to `JSContext` (`CreateErrorNoteVA`) and back (subsequent calls)? Pretty long call stack: ``` > xul.dll!js::gc::AutoSuppressGC::AutoSuppressGC(js::ExclusiveContext * cx) Line 6311 C++ xul.dll!ExpandErrorArgumentsHelper<JSErrorNotes::Note>(js::ExclusiveContext * cx, const JSErrorFormatString *(*)(void *, const unsigned int) callback, void * userRef, const unsigned int errorNumber, const char16_t * * messageArgs, js::ErrorArgumentsType argumentsType, JSErrorNotes::Note * reportp, char * ap) Line 651 C++ xul.dll!CreateErrorNoteVA(JSContext * cx, const char * filename, unsigned int lineno, unsigned int column, const JSErrorFormatString *(*)(void *, const unsigned int) errorCallback, void * userRef, const unsigned int errorNumber, js::ErrorArgumentsType argumentsType, char * ap) Line 6344 C++ xul.dll!JSErrorNotes::addNoteASCII(js::ExclusiveContext * cx, const char * filename, unsigned int lineno, unsigned int column, const JSErrorFormatString *(*)(void *, const unsigned int) errorCallback, void * userRef, const unsigned int errorNumber, ...) Line 6364 C++ xul.dll!js::frontend::Parser<js::frontend::SyntaxParseHandler>::reportMissingClosing(unsigned int errorNumber, unsigned int noteNumber, unsigned int openedPos) Line 1049 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::arrayInitializer(js::frontend::YieldHandling yieldHandling, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError) Line 9467 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::primaryExpr(js::frontend::YieldHandling yieldHandling, js::frontend::TripledotHandling tripledotHandling, js::frontend::TokenKind tt, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError, js::frontend::ParserBase::InvokedPrediction invoked) Line 10190 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::memberExpr(js::frontend::YieldHandling yieldHandling, js::frontend::TripledotHandling tripledotHandling, js::frontend::TokenKind tt, bool allowCallSyntax, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError, js::frontend::ParserBase::InvokedPrediction invoked) Line 8933 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::unaryExpr(js::frontend::YieldHandling yieldHandling, js::frontend::TripledotHandling tripledotHandling, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError, js::frontend::ParserBase::InvokedPrediction invoked) Line 8464 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::assignExpr(js::frontend::InHandling inHandling, js::frontend::YieldHandling yieldHandling, js::frontend::TripledotHandling tripledotHandling, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError, js::frontend::ParserBase::InvokedPrediction invoked) Line 8139 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::initializerInNameDeclaration(js::frontend::ParseNode * decl, js::frontend::ParseNode * binding, JS::Handle<js::PropertyName *> name, js::frontend::DeclarationKind declKind, bool initialDeclaration, js::frontend::YieldHandling yieldHandling, js::frontend::ParseNodeKind * forHeadKind, js::frontend::ParseNode * * forInOrOfExpression) Line 4716 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::declarationName(js::frontend::ParseNode * decl, js::frontend::DeclarationKind declKind, js::frontend::TokenKind tt, bool initialDeclaration, js::frontend::YieldHandling yieldHandling, js::frontend::ParseNodeKind * forHeadKind, js::frontend::ParseNode * * forInOrOfExpression) Line 4822 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::declarationList(js::frontend::YieldHandling yieldHandling, js::frontend::ParseNodeKind kind, js::frontend::ParseNodeKind * forHeadKind, js::frontend::ParseNode * * forInOrOfExpression) Line 4912 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::statementListItem(js::frontend::YieldHandling yieldHandling, bool canHaveDirectives) Line 7654 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::statementList(js::frontend::YieldHandling yieldHandling) Line 4074 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::functionBody(js::frontend::InHandling inHandling, js::frontend::YieldHandling yieldHandling, js::frontend::FunctionSyntaxKind kind, js::frontend::Parser<js::frontend::FullParseHandler>::FunctionBodyType type) Line 2657 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::functionFormalParametersAndBody(js::frontend::InHandling inHandling, js::frontend::YieldHandling yieldHandling, js::frontend::ParseNode * pn, js::frontend::FunctionSyntaxKind kind, mozilla::Maybe<unsigned int> parameterListEnd, bool isStandaloneFunction) Line 3702 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::innerFunction(js::frontend::ParseNode * pn, js::frontend::ParseContext * outerpc, js::frontend::FunctionBox * funbox, unsigned int toStringStart, js::frontend::InHandling inHandling, js::frontend::YieldHandling yieldHandling, js::frontend::FunctionSyntaxKind kind, js::frontend::Directives inheritedDirectives, js::frontend::Directives * newDirectives) Line 3503 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::trySyntaxParseInnerFunction(js::frontend::ParseNode * pn, JS::Handle<JSFunction *> fun, unsigned int toStringStart, js::frontend::InHandling inHandling, js::frontend::YieldHandling yieldHandling, js::frontend::FunctionSyntaxKind kind, js::GeneratorKind generatorKind, js::FunctionAsyncKind asyncKind, bool tryAnnexB, js::frontend::Directives inheritedDirectives, js::frontend::Directives * newDirectives) Line 3463 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::functionDefinition(unsigned int toStringStart, js::frontend::ParseNode * pn, js::frontend::InHandling inHandling, js::frontend::YieldHandling yieldHandling, JS::Handle<JSAtom *> funName, js::frontend::FunctionSyntaxKind kind, js::GeneratorKind generatorKind, js::FunctionAsyncKind asyncKind, bool tryAnnexB) Line 3366 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::functionExpr(unsigned int toStringStart, js::frontend::ParserBase::InvokedPrediction invoked, js::FunctionAsyncKind asyncKind) Line 3890 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::primaryExpr(js::frontend::YieldHandling yieldHandling, js::frontend::TripledotHandling tripledotHandling, js::frontend::TokenKind tt, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError, js::frontend::ParserBase::InvokedPrediction invoked) Line 10190 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::memberExpr(js::frontend::YieldHandling yieldHandling, js::frontend::TripledotHandling tripledotHandling, js::frontend::TokenKind tt, bool allowCallSyntax, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError, js::frontend::ParserBase::InvokedPrediction invoked) Line 8933 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::unaryExpr(js::frontend::YieldHandling yieldHandling, js::frontend::TripledotHandling tripledotHandling, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError, js::frontend::ParserBase::InvokedPrediction invoked) Line 8464 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::assignExpr(js::frontend::InHandling inHandling, js::frontend::YieldHandling yieldHandling, js::frontend::TripledotHandling tripledotHandling, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError, js::frontend::ParserBase::InvokedPrediction invoked) Line 8139 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::objectLiteral(js::frontend::YieldHandling yieldHandling, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError) Line 9750 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::primaryExpr(js::frontend::YieldHandling yieldHandling, js::frontend::TripledotHandling tripledotHandling, js::frontend::TokenKind tt, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError, js::frontend::ParserBase::InvokedPrediction invoked) Line 10190 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::memberExpr(js::frontend::YieldHandling yieldHandling, js::frontend::TripledotHandling tripledotHandling, js::frontend::TokenKind tt, bool allowCallSyntax, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError, js::frontend::ParserBase::InvokedPrediction invoked) Line 8933 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::unaryExpr(js::frontend::YieldHandling yieldHandling, js::frontend::TripledotHandling tripledotHandling, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError, js::frontend::ParserBase::InvokedPrediction invoked) Line 8464 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::assignExpr(js::frontend::InHandling inHandling, js::frontend::YieldHandling yieldHandling, js::frontend::TripledotHandling tripledotHandling, js::frontend::Parser<js::frontend::FullParseHandler>::PossibleError * possibleError, js::frontend::ParserBase::InvokedPrediction invoked) Line 8139 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::initializerInNameDeclaration(js::frontend::ParseNode * decl, js::frontend::ParseNode * binding, JS::Handle<js::PropertyName *> name, js::frontend::DeclarationKind declKind, bool initialDeclaration, js::frontend::YieldHandling yieldHandling, js::frontend::ParseNodeKind * forHeadKind, js::frontend::ParseNode * * forInOrOfExpression) Line 4716 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::declarationName(js::frontend::ParseNode * decl, js::frontend::DeclarationKind declKind, js::frontend::TokenKind tt, bool initialDeclaration, js::frontend::YieldHandling yieldHandling, js::frontend::ParseNodeKind * forHeadKind, js::frontend::ParseNode * * forInOrOfExpression) Line 4822 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::declarationList(js::frontend::YieldHandling yieldHandling, js::frontend::ParseNodeKind kind, js::frontend::ParseNodeKind * forHeadKind, js::frontend::ParseNode * * forInOrOfExpression) Line 4912 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::variableStatement(js::frontend::YieldHandling yieldHandling) Line 7377 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::statementListItem(js::frontend::YieldHandling yieldHandling, bool canHaveDirectives) Line 7603 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::statementList(js::frontend::YieldHandling yieldHandling) Line 4074 C++ xul.dll!js::frontend::Parser<js::frontend::FullParseHandler>::globalBody(js::frontend::GlobalSharedContext * globalsc) Line 2180 C++ xul.dll!BytecodeCompiler::compileScript(JS::Handle<JSObject *> environment, js::frontend::SharedContext * sc) Line 341 C++ xul.dll!js::frontend::CompileGlobalScript(js::ExclusiveContext * cx, js::LifoAlloc & alloc, js::ScopeKind scopeKind, const JS::ReadOnlyCompileOptions & options, JS::SourceBufferHolder & srcBuf, js::SourceCompressionTask * extraSct, js::ScriptSourceObject * * sourceObjectOut) Line 577 C++ xul.dll!js::ScriptParseTask::parse() Line 370 C++ xul.dll!js::HelperThread::handleParseWorkload(js::AutoLockHelperThreadState & locked, unsigned int stackLimit) Line 1629 C++ xul.dll!js::HelperThread::threadLoop() Line 1883 C++ xul.dll!js::detail::ThreadTrampoline<void (__cdecl&)(void *),js::HelperThread *>::Start(void * aPack) Line 228 C++ ucrtbase.dll!__crt_at_quick_exit() Unknown kernel32.dll!@BaseThreadInitThunk@12() Unknown ntdll.dll!___RtlUserThreadStart@8() Unknown ntdll.dll!__RtlUserThreadStart@8() Unknown ``` @g4jc can you have a look at this please? Seems we lost the exclusive context in the parser chain somewhere in this call stack.
g4jc commented 1 year ago (Migrated from github.com)
Owner

Yes, I see the issue. Falling off main thread due to errant use of JSContext in CreateErrorNoteVA during the backport of 1283712. Failed to catch it during Make JSErrorNotes Single Threaded.

Patch incoming.

Yes, I see the issue. Falling off main thread due to errant use of `JSContext` in `CreateErrorNoteVA` during the backport of [1283712](https://github.com/MoonchildProductions/UXP/commit/9a7113f7c8d89d27558942f42603c4edee779d20#diff-84ee602d6f00e281ca8bf8febc7671c0R6329). Failed to catch it during [Make JSErrorNotes Single Threaded](https://github.com/MoonchildProductions/UXP/commit/3765f057896718bfca3056728a485448bfb411cb). Patch incoming.
g4jc commented 1 year ago (Migrated from github.com)
Owner

Had to trace down the contexts a little deeper than expected, but ErrorNotes are functioning properly now. One of the few times a typo in an Add-On is great to have for debugging purposes!

Note to self: Most of the time a context->asJSContext() conversion is a bad idea and masks the larger problem of one of the functions being off-thread.

Had to trace down the contexts a little deeper than expected, but `ErrorNotes` are functioning properly now. One of the few times a typo in an Add-On is great to have for debugging purposes! Note to self: Most of the time a `context->asJSContext()` conversion is a bad idea and masks the larger problem of one of the functions being off-thread.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Apply labels
Clear labels
App: All App: Basilisk App: Borealis App: Fennec App: IceApe App: IceDove App: IceWeasel App: Interlink App: Pale Moon App: Toolkit Assigned Backed Out Bitrotted Bounty
This issue is eligible for payment of a bounty. Bounty paid
Bounty issue fully completed and paid. Bug Build Bustage C: Add-ons Manager C: Build System C: DevTools C: DOM C: Editor
HTML editor and editable HTML elements C: Extensions C: Images
Image codecs and image handling C: Installer/Updater C: Javascript C: Layout C: Layout - CSS C: MailNews Core
MailNews, Mork, and LDAP C: Media C: Media - EME C: Media - WebRTC C: Memory C: Networking C: Parser
Dealing with the XML/HTML parser C: Places
Bookmarks/History/Library C: Plugins C: Printing C: Rendering C: SessionStore C: Sync C: Theme C: UI C: WebExAM
The WebExtensions enabled Add-ons Manager C: Widget Code Cleanup Crash Critical Debug: Build
Debug Build Issues Debug: Runtime
Debug Runtime Issues dependencies
Pull requests that update a dependency file Done
Like fixed but merely done Duplicate Enhancement Everybody Wins!
For those really rare occasions where everyone agrees in the end. Fixed Good Enough Good first issue
Good issue for contributers new to the project. Hang High Priority High Risk Incomplete Invalid Leave open Legal Localization Low Priority Low Risk Meta-issue More info needed Mozregression Wanted
Regression window or fix window wanted on mozilla-central with mozregression. Not an Issue On Hold OS: Android OS: Linux OS: Linux (AltArch)
Linux on other architectures such as ARM and PPC OS: Mac OS X OS: Other OS: Solaris / Illumos OS: Windows Performance PR requested
Issue with code work but no PR. PR: Draft - DO NOT MERGE Privacy Product Polish Question Redirected to Forum Regression Release Engineering Research Retarded
Do not use this label Review: r+ Review: r- Review: r? Security Services
Related to services provided for applications. Stale Standards Compliance String Changes Super Critical II Turbo Revival The whole codebase
Affects many components Theme Changes Unconfirmed Verification Needed Verified Wanted: Release Uplift Web Compatibility WebGL/3D
Related to WebGL(2) and 3D object rendering code. Won't Fix Works for me
No Label
App: All
App: Basilisk
App: Borealis
App: Fennec
App: IceApe
App: IceDove
App: IceWeasel
App: Interlink
App: Pale Moon
App: Toolkit
Assigned
Backed Out
Bitrotted
Bounty
Bounty paid
Bug
Build Bustage
C: Add-ons Manager
C: Build System
C: DevTools
C: DOM
C: Editor
C: Extensions
C: Images
C: Installer/Updater
C: Javascript
C: Layout
C: Layout - CSS
C: MailNews Core
C: Media
C: Media - EME
C: Media - WebRTC
C: Memory
C: Networking
C: Parser
C: Places
C: Plugins
C: Printing
C: Rendering
C: SessionStore
C: Sync
C: Theme
C: UI
C: WebExAM
C: Widget
Code Cleanup
Crash
Critical
Debug: Build
Debug: Runtime
dependencies
Done
Duplicate
Enhancement
Everybody Wins!
Fixed
Good Enough
Good first issue
Hang
High Priority
High Risk
Incomplete
Invalid
Leave open
Legal
Localization
Low Priority
Low Risk
Meta-issue
More info needed
Mozregression Wanted
Not an Issue
On Hold
OS: Android
OS: Linux
OS: Linux (AltArch)
OS: Mac OS X
OS: Other
OS: Solaris / Illumos
OS: Windows
Performance
PR requested
PR: Draft - DO NOT MERGE
Privacy
Product Polish
Question
Redirected to Forum
Regression
Release Engineering
Research
Retarded
Review: r+
Review: r-
Review: r?
Security
Services
Stale
Standards Compliance
String Changes
Super Critical II Turbo Revival
The whole codebase
Theme Changes
Unconfirmed
Verification Needed
Verified
Wanted: Release Uplift
Web Compatibility
WebGL/3D
Won't Fix
Works for me
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes