Remove the ability to accept Firefox GUIDS (remove the dual system)
#1744
Closed
opened 2 years ago by Moonchild
·
2 comments
No Branch/Tag Specified
1210
1791
1805-stacksize
1970-form-focusring-styling
28.9-platform
28.9-platform-old
ANGLE-update
Basilisk-release
CCW-perf
Pale_Moon-release
RFC6367
VS2017
aruba
dynamic-module-import
eme
fetchstreams-work
freebsd-support
getnativepath-work
js-modules
libaom-update
master
modulefix
nss-gyp
nss-gyp-work
nss-update-work
pref-dual-guid
redwood
release
release-29
v8re-shim-build
v8re-shim-work
xpiprovider-work
29.4.6_RC1
31.0.0_RC1
31.0.0_RC2
Checkpoint_1
FF_Checkpoint_1
FullFunction_CP1
NSS_3.35_TEST
PM28.0.0.1_Release
PM28.0.0_Build1
PM28.0.0_Release
PM28.0.0a2_Unstable
PM28.0.0a3_Unstable
PM28.0.0a4_Unstable
PM28.0.0b1_Unstable
PM28.0.0b2_Unstable
PM28.0.0b3_Unstable
PM28.0.0b4_Unstable
PM28.0.0b5_Unstable
PM28.0.1_Release
PM28.1.0_Release
PM28.2.0_Release
PM28.2.1_Release
PM28.2.2_Release
PM28.3.0_Release
PM28.3.1_Release
PM28.4.0_Release
PM28.4.1_Release
PM28.5.0_Release
PM28.5.1_Release
PM28.5.2_Release
PM28.6.0.1_Release
PM28.6.0_Release
PM28.6.1_Release
PM28.7.0_Release
PM28.7.1_Release
PM28.7.2_Release
PM28.8.0_Release
PM28.8.1_Release
PM28.8.2.1_Release
PM28.8.2_Release
PM28.8.3_Release
PM28.8.4_Release
RB20220707
RB_20220510
RB_20220607
RB_20220607_2
RB_20220802
RB_29.4.5
RB_29.4.5-UXP
RB_29.4.5.1
RB_29.4.5.1-UXP
RB_29.4.6
RC_20200924
RC_20201024
RC_20201120
RC_20201215
RC_20201216
RC_20210128
RC_20210130
RC_20210225
RC_20210226
RC_20210326
RC_20210421
RC_20210604
RC_20210715
RC_20210813
RC_20210815
RC_20211105
RC_20211209
RC_20220114
RC_20220409
RC_20220507
RC_20220728
RELBASE_20200324
RELBASE_20200408
RELBASE_20200426
RELBASE_20200427
RELBASE_20200506
RELBASE_20200603
RELBASE_20200711
RELBASE_20200712
RELBASE_20200730
RELBASE_20200831
RELBASE_20200901
RELBASE_20200929
RELBASE_20200930
RELBASE_20201001
RELBASE_20201024
RELBASE_20201120
RELBASE_20201124
RELBASE_20201218
RELBASE_20210202
RELBASE_20210205
RELBASE_20210302
RELBASE_20210330
RELBASE_20210427
RELBASE_20210608
RELBASE_20210719
RELBASE_20210817
RELBASE_20210823
RELBASE_20210914
RELBASE_20210914-UXP
RELBASE_20211109
RELBASE_20211109-UXP
RELBASE_20211110
RELBASE_20211110-UXP
RELBASE_20211214
RELBASE_20211214-UXP
RELBASE_20220118
RELBASE_20220118-UXP
RELBASE_20220127
RELBASE_20220127-UXP
v2018.04.23
v2018.04.26
v2018.04.27
v2018.05.15
v2018.06.01
v2018.07.18
v2018.09.05
v2018.09.27
v2018.11.04
v2018.11.07
v2018.12.18
v2019.02.11
v2019.03.08
v2019.03.27
v2019.06.08
v2019.09.03
v2019.09.12
v2019.10.31
v2020.01.12
v2020.02.06
v2020.02.18
Labels
This issue is eligible for payment of a bounty. Bounty paid
Bounty issue fully completed and paid. Bug Build Bustage Build System Code Cleanup Crash Critical Debug: Build
Debug Build Issues Debug: Runtime
Debug Runtime Issues dependencies
Pull requests that update a dependency file Devtools Documentation DOM Done
Like fixed but merely done Duplicate Editor
HTML editor and editable HTML elements Enhancement Everybody Wins!
For those really rare occasions where everyone agrees in the end. Extensions Fixed Good Enough Good first issue
Good issue for contributers new to the project. Hang High Priority High Risk Images
Image codecs and image handling Incomplete Installer/Updater Intermittent Invalid Javascript Layout Layout - CSS Leave open Legal Localization Low Priority Low Risk MailNews Core
MailNews, Mork, and LDAP Media Memory Meta-issue More info needed Networking Not an Issue On Hold OS: Android OS: Linux OS: Linux (AltArch)
Linux on other architectures such as ARM and PPC OS: Mac OS X OS: Other OS: Solaris / Illumos OS: Windows Parser
Dealing with the XML/HTML parser Performance Places
Bookmarks/History/Library Plugins PR requested
Issue with code work but no PR. PR: Draft - DO NOT MERGE Printing Privacy Product Polish Question Redirected to Forum Regression Regression-window Wanted
Regression window or fix window wanted (either on mozilla-central with mozregression, or manual on our tree). Release Engineering Release Uplift Wanted Rendering Research Retarded
Do not use this label Security Services
Related to services provided for applications. SessionStore Stale Standards Compliance String Changes Sync The whole codebase
Affects many components Theme Theme Changes UI
User Interface Unconfirmed Verification Needed Verified Web Compatibility WebGL/3D
Related to WebGL(2) and 3D object rendering code. Widget Won't Fix Works for me
Apply labels
Clear labels
Add-ons Manager
App: All
App: Basilisk
App: Fennec
App: IceApe
App: IceDove
App: IceWeasel
App: Interlink
App: Pale Moon
App: Toolkit
Assigned
Backed Out
Bitrotted
Bounty
This issue is eligible for payment of a bounty. Bounty paid
Bounty issue fully completed and paid. Bug Build Bustage Build System Code Cleanup Crash Critical Debug: Build
Debug Build Issues Debug: Runtime
Debug Runtime Issues dependencies
Pull requests that update a dependency file Devtools Documentation DOM Done
Like fixed but merely done Duplicate Editor
HTML editor and editable HTML elements Enhancement Everybody Wins!
For those really rare occasions where everyone agrees in the end. Extensions Fixed Good Enough Good first issue
Good issue for contributers new to the project. Hang High Priority High Risk Images
Image codecs and image handling Incomplete Installer/Updater Intermittent Invalid Javascript Layout Layout - CSS Leave open Legal Localization Low Priority Low Risk MailNews Core
MailNews, Mork, and LDAP Media Memory Meta-issue More info needed Networking Not an Issue On Hold OS: Android OS: Linux OS: Linux (AltArch)
Linux on other architectures such as ARM and PPC OS: Mac OS X OS: Other OS: Solaris / Illumos OS: Windows Parser
Dealing with the XML/HTML parser Performance Places
Bookmarks/History/Library Plugins PR requested
Issue with code work but no PR. PR: Draft - DO NOT MERGE Printing Privacy Product Polish Question Redirected to Forum Regression Regression-window Wanted
Regression window or fix window wanted (either on mozilla-central with mozregression, or manual on our tree). Release Engineering Release Uplift Wanted Rendering Research Retarded
Do not use this label Security Services
Related to services provided for applications. SessionStore Stale Standards Compliance String Changes Sync The whole codebase
Affects many components Theme Theme Changes UI
User Interface Unconfirmed Verification Needed Verified Web Compatibility WebGL/3D
Related to WebGL(2) and 3D object rendering code. Widget Won't Fix Works for me
No Label
Add-ons Manager
App: All
App: Basilisk
App: Fennec
App: IceApe
App: IceDove
App: IceWeasel
App: Interlink
App: Pale Moon
App: Toolkit
Assigned
Backed Out
Bitrotted
Bounty
Bounty paid
Bug
Build Bustage
Build System
Code Cleanup
Crash
Critical
Debug: Build
Debug: Runtime
dependencies
Devtools
Documentation
DOM
Done
Duplicate
Editor
Enhancement
Everybody Wins!
Extensions
Fixed
Good Enough
Good first issue
Hang
High Priority
High Risk
Images
Incomplete
Installer/Updater
Intermittent
Invalid
Javascript
Layout
Layout - CSS
Leave open
Legal
Localization
Low Priority
Low Risk
MailNews Core
Media
Memory
Meta-issue
More info needed
Networking
Not an Issue
On Hold
OS: Android
OS: Linux
OS: Linux (AltArch)
OS: Mac OS X
OS: Other
OS: Solaris / Illumos
OS: Windows
Parser
Performance
Places
Plugins
PR requested
PR: Draft - DO NOT MERGE
Printing
Privacy
Product Polish
Question
Redirected to Forum
Regression
Regression-window Wanted
Release Engineering
Release Uplift Wanted
Rendering
Research
Retarded
Security
Services
SessionStore
Stale
Standards Compliance
String Changes
Sync
The whole codebase
Theme
Theme Changes
UI
Unconfirmed
Verification Needed
Verified
Web Compatibility
WebGL/3D
Widget
Won't Fix
Works for me
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.
No due date set.
Blocks
#1444 Phase out the dual-GUID system
MoonchildProductions/UXP
Reference: MoonchildProductions/UXP#1744
Reference in new issue
There is no content yet.
Delete Branch '%!s(<nil>)'
Deleting a branch is permanent. It CANNOT be undone. Continue?
No
Yes
Time for this long-term-temporary measure to be gone from the toolkit.
This will remove the ability of UXP applications (in particular Pale Moon) to accept add-ons that target a different GUID (specifically Firefox) for installation/use than the native application ID or generic toolkit ID.
@athenian200 it's been a week - are you still working on this?
Yeah, I actually 90% finished this a while ago. I removed everything enclosed by MOZ_PHOENIX_EXTENSIONS. I just had a couple of questions. Is FIREFOX_ID actually used for anything aside from the MOZ_PHOENIX_EXTENSION code? I left the FIREFOX_ID constants alone where not enclosed in MOZ_PHOENIX_EXTENSION ifdefs because I think Basilisk might use it.
Also, I was wondering if I need to open a seperate issue for the Pale Moon application part of this, since that code seems to touch the application side as well as the toolkit. What I wound up doing was creating two PRs: One in the UXP repo, and another in the Pale-Moon repo referencing this issue in the commit, but I can do it a different way if desired.