#1744 Remove the ability to accept Firefox GUIDS (remove the dual system)

Closed
opened 1 month ago by Moonchild · 2 comments

Time for this long-term-temporary measure to be gone from the toolkit.

This will remove the ability of UXP applications (in particular Pale Moon) to accept add-ons that target a different GUID (specifically Firefox) for installation/use than the native application ID or generic toolkit ID.

Time for this long-term-temporary measure to be gone from the toolkit. This will remove the ability of UXP applications (in particular Pale Moon) to accept add-ons that target a different GUID (specifically Firefox) for installation/use than the native application ID or generic toolkit ID.
Moonchild added the
App: Pale Moon
label 1 month ago
Moonchild added the
App: Toolkit
label 1 month ago
Moonchild added the
C: Add-ons Manager
label 1 month ago
Moonchild added a new dependency 1 month ago
athenian200 was assigned by mattatobin 1 month ago
Moonchild added this to the 29.2.0 milestone 1 month ago
Moonchild commented 1 month ago
Owner

@athenian200 it’s been a week - are you still working on this?

@athenian200 it's been a week - are you still working on this?
athenian200 commented 1 month ago
Collaborator

Yeah, I actually 90% finished this a while ago. I removed everything enclosed by MOZ_PHOENIX_EXTENSIONS. I just had a couple of questions. Is FIREFOX_ID actually used for anything aside from the MOZ_PHOENIX_EXTENSION code? I left the FIREFOX_ID constants alone where not enclosed in MOZ_PHOENIX_EXTENSION ifdefs because I think Basilisk might use it.

Also, I was wondering if I need to open a seperate issue for the Pale Moon application part of this, since that code seems to touch the application side as well as the toolkit. What I wound up doing was creating two PRs: One in the UXP repo, and another in the Pale-Moon repo referencing this issue in the commit, but I can do it a different way if desired.

Yeah, I actually 90% finished this a while ago. I removed everything enclosed by MOZ_PHOENIX_EXTENSIONS. I just had a couple of questions. Is FIREFOX_ID actually used for anything aside from the MOZ_PHOENIX_EXTENSION code? I left the FIREFOX_ID constants alone where not enclosed in MOZ_PHOENIX_EXTENSION ifdefs because I think Basilisk might use it. Also, I was wondering if I need to open a seperate issue for the Pale Moon application part of this, since that code seems to touch the application side as well as the toolkit. What I wound up doing was creating two PRs: One in the UXP repo, and another in the Pale-Moon repo referencing this issue in the commit, but I can do it a different way if desired.
mattatobin added the
Fixed
label 1 month ago
mattatobin closed this issue 1 month ago
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Blocks
#1444 Phase out the dual-GUID system
MoonchildProductions/UXP
Loading…
There is no content yet.