Implement missing calculation support for stroke dashOffset #1781

What it says on the tin.
We have calc() support for lineheight, but not for stroke values. This was touched on in #1657. I ran into this checking the deps for calc-in-color and this is probably needed before we can implement that one.

What it says on the tin. We have `calc()` support for lineheight, but not for stroke values. This was touched on in #1657. I ran into this checking the deps for calc-in-color and this is probably needed before we can implement that one.

Test fiddle: https://jsfiddle.net/7hf615oe/

Tested animation with a real-world example test https://codepen.io/tellaho/pen/PPRjbj/

@@ -4640,8 +4640,8 @@
   MergeMultiplicativeR(nsCSSUnit aCalcFunction,
                        result_type aValue1, float aValue2)
   {
-    MOZ_ASSERT(aCalcFunction == eCSSUnit_Calc_TimesR ||
-               aCalcFunction == eCSSUnit_Divided,
+    MOZ_ASSERT(aCalcFunction == eCSSUnit_Calc_Times_R ||
+               aCalcFunction == eCSSUnit_Calc_Divided,
                "unexpected unit");
     result_type result;
     if (aCalcFunction == eCSSUnit_Calc_Divided) {

``` @@ -4640,8 +4640,8 @@ MergeMultiplicativeR(nsCSSUnit aCalcFunction, result_type aValue1, float aValue2) { - MOZ_ASSERT(aCalcFunction == eCSSUnit_Calc_TimesR || - aCalcFunction == eCSSUnit_Divided, + MOZ_ASSERT(aCalcFunction == eCSSUnit_Calc_Times_R || + aCalcFunction == eCSSUnit_Calc_Divided, "unexpected unit"); result_type result; if (aCalcFunction == eCSSUnit_Calc_Divided) { ```

explain

debug build fails, the assert doesn't compile because eCSSUnit_Calc_TimesR and eCSSUnit_Divided are not defined. typo?

debug build fails, the assert doesn't compile because ```eCSSUnit_Calc_TimesR``` and ```eCSSUnit_Divided``` are not defined. typo?

Ah, right. Thanks. patched.

Labels Milestones

Implement missing calculation support for stroke dashOffset #1781