MoonchildProductions
/
UXP
14
16
Fork 26
Code Issues 130 Pull Requests Releases 83 Activity

Labels Milestones

New Issue

Switch to the newer ICU normalizer API for js string normalization #1999

Closed
opened 9 months ago by Moonchild · 0 comments
Moonchild commented 9 months ago
Owner

It's unsure why Mozilla chose to use the old and deprecated unorm API when ICU has had unorm2 since 4.4 -- way before js string normalization was a thing in ES6.

This throws deprecation warnings when compiling, and is likely slower than the new API.

I don't think this is a particularly complex changeover but will require a bit of work since unorm2 is an instanced API instead of static.

It's unsure why Mozilla chose to use the old and deprecated `unorm` API when ICU has had `unorm2` since 4.4 -- way before js string normalization was a thing in ES6. This throws deprecation warnings when compiling, and is likely slower than the new API. I don't think this is a particularly complex changeover but will require a bit of work since `unorm2` is an instanced API instead of static.
Moonchild added this to the 31.3.0 milestone 9 months ago
Moonchild added the
Javascript
Performance
 labels 9 months ago
Moonchild self-assigned this 9 months ago
Moonchild closed this issue 9 months ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
fips-work
release
hourCycle-work
2176
trackingprotection-cleanup
full-range-video
irregexp-upgrades
1769-take2
z-index-work
regexp-hookup-v2
scroll-anchoring-wip
re-unify
1210
getnativepath-work
release-29
1791
redwood
nss-update-work
dynamic-module-import
modulefix
fetchstreams-work
xpiprovider-work
aruba
28.9-platform
28.9-platform-old
RFC6367
Pale_Moon-release
js-modules
CCW-perf
RB_20230515
RC_20230511
RB_20230417
RC_20230413
RB_20230320
RC_20230317
RB_20230219
RB_20230123
Goanna_6.0.0
RB_20221220
RC_20221216
RB_20221129
RB_20221122
RC_20221120_2
RC_20221120
RB_20221101
RC_20221026
RB_20220928
RB_20220927
RC_20220924
RC_20220922
RB_20220802
RC_20220728
RB20220707
RB_20220607_2
RB_20220607
RB_20220510
31.0.0_RC2
31.0.0_RC1
RC_20220507
RB_29.4.6
RC_20220409
29.4.6_RC1
RB_29.4.5-UXP
RB_29.4.5.1-UXP
RELBASE_20220127-UXP
RELBASE_20220118-UXP
RELBASE_20211214-UXP
RELBASE_20211110-UXP
RELBASE_20211109-UXP
RELBASE_20210914-UXP
RB_29.4.5.1
RB_29.4.5
RELBASE_20220320
RELBASE_20220310
RC_20220309
RC_20220219
RC_20220216
RC_20220214
RELBASE_20220127
RELBASE_20220118
RC_20220114
RELBASE_20211214
RC_20211209
RELBASE_20211110
RELBASE_20211109
RC_20211105
RELBASE_20210914
RELBASE_20210823
RELBASE_20210817
RC_20210815
RC_20210813
RELBASE_20210719
RC_20210715
RELBASE_20210608
RC_20210604
RELBASE_20210427
RC_20210421
RELBASE_20210330
RC_20210326
RELBASE_20210302
RC_20210226
RC_20210225
RELBASE_20210205
RELBASE_20210202
RC_20210130
RC_20210128
RELBASE_20201218
RC_20201216
RC_20201215
RELBASE_20201124
RELBASE_20201120
RC_20201120
RELBASE_20201024
RC_20201024
RELBASE_20201001
RELBASE_20200930
RELBASE_20200929
RC_20200924
RELBASE_20200901
RELBASE_20200831
RELBASE_20200730
RELBASE_20200712
RELBASE_20200711
RELBASE_20200603
RELBASE_20200506
RELBASE_20200427
RELBASE_20200426
RELBASE_20200408
RELBASE_20200324
PM28.8.4_Release
v2020.02.18
PM28.8.3_Release
v2020.02.06
PM28.8.2.1_Release
PM28.8.2_Release
v2020.01.12
PM28.8.1_Release
PM28.8.0_Release
v2019.10.31
PM28.7.2_Release
v2019.09.12
PM28.7.1_Release
v2019.09.03
PM28.7.0_Release
PM28.6.1_Release
PM28.6.0.1_Release
PM28.6.0_Release
v2019.06.08
PM28.5.2_Release
PM28.5.1_Release
PM28.5.0_Release
PM28.4.1_Release
v2019.03.27
v2019.03.08
PM28.4.0_Release
v2019.02.11
PM28.3.1_Release
PM28.3.0_Release
v2018.12.18
PM28.2.2_Release
PM28.2.1_Release
PM28.2.0_Release
v2018.11.07
v2018.11.04
v2018.09.27
PM28.1.0_Release
v2018.09.05
PM28.0.1_Release
PM28.0.0.1_Release
PM28.0.0_Release
PM28.0.0_Build1
PM28.0.0b5_Unstable
PM28.0.0b4_Unstable
v2018.07.18
PM28.0.0b3_Unstable
PM28.0.0b2_Unstable
PM28.0.0b1_Unstable
PM28.0.0a4_Unstable
NSS_3.35_TEST
PM28.0.0a3_Unstable
v2018.06.01
PM28.0.0a2_Unstable
v2018.05.15
v2018.04.27
v2018.04.26
v2018.04.23
Checkpoint_1
FullFunction_CP1
FF_Checkpoint_1
Labels
Apply labels
Clear labels   
Add-ons Manager
   
App: All
   
App: Basilisk
   
App: Fennec
   
App: IceApe
   
App: IceDove
   
App: IceWeasel
   
App: Interlink
   
App: Pale Moon
   
App: Toolkit
   
Assigned
   
Backed Out
   
Bitrotted
   
Bounty

This issue is eligible for payment of a bounty.   
Bounty paid

Bounty issue fully completed and paid.   
Bug
   
Build Bustage
   
Build System
   
Code Cleanup
   
Crash
   
Critical
   
Debug: Build

Debug Build Issues   
Debug: Runtime

Debug Runtime Issues   
dependencies

Pull requests that update a dependency file   
Devtools
   
Documentation
   
DOM
   
Done

Like fixed but merely done   
Duplicate
   
Editor

HTML editor and editable HTML elements   
Enhancement
   
Everybody Wins!

For those really rare occasions where everyone agrees in the end.   
Extensions
   
Fixed
   
Good Enough
   
Good first issue

Good issue for contributers new to the project.   
Hang
   
High Priority
   
High Risk
   
Images

Image codecs and image handling   
Incomplete
   
Installer/Updater
   
Intermittent
   
Invalid
   
Javascript
   
Layout
   
Layout - CSS
   
Leave open
   
Legal
   
Localization
   
Low Priority
   
Low Risk
   
MailNews Core

MailNews, Mork, and LDAP   
Media
   
Memory
   
Meta-issue
   
MFBT

Headers, data structures, methods, etc in mfbt/ that are global to the entirety of UXP code.   
More info needed
   
Networking
   
Not an Issue
   
On Hold
   
OS: Android
   
OS: Linux
   
OS: Linux (AltArch)

Linux on other architectures such as ARM and PPC   
OS: Mac OS X
   
OS: Other
   
OS: Solaris / Illumos
   
OS: Windows
   
Parser

Dealing with the XML/HTML parser   
Performance
   
Places

Bookmarks/History/Library   
Plugins
   
PR requested

Issue with code work but no PR.   
PR: Draft - DO NOT MERGE
   
Printing
   
Privacy
   
Product Polish
   
Question
   
Redirected to Forum
   
Regression
   
Regression-window Wanted

Regression window or fix window wanted (either on mozilla-central with mozregression, or manual on our tree).   
Release Engineering
   
Release Uplift Wanted
   
Rendering
   
Research
   
Retarded

Do not use this label   
Security
   
Services

Related to services provided for applications.   
SessionStore
   
Stale
   
Standards Compliance
   
String Changes
   
Sync
   
The whole codebase

Affects many components   
Theme
   
Theme Changes
   
UI

User Interface   
Unconfirmed
   
Verification Needed
   
Verified
   
Web Compatibility
   
WebGL/3D

Related to WebGL(2) and 3D object rendering code.   
Widget
   
Won't Fix
   
Works for me
No Label
Add-ons Manager
App: All
App: Basilisk
App: Fennec
App: IceApe
App: IceDove
App: IceWeasel
App: Interlink
App: Pale Moon
App: Toolkit
Assigned
Backed Out
Bitrotted
Bounty
Bounty paid
Bug
Build Bustage
Build System
Code Cleanup
Crash
Critical
Debug: Build
Debug: Runtime
dependencies
Devtools
Documentation
DOM
Done
Duplicate
Editor
Enhancement
Everybody Wins!
Extensions
Fixed
Good Enough
Good first issue
Hang
High Priority
High Risk
Images
Incomplete
Installer/Updater
Intermittent
Invalid
Javascript
Layout
Layout - CSS
Leave open
Legal
Localization
Low Priority
Low Risk
MailNews Core
Media
Memory
Meta-issue
MFBT
More info needed
Networking
Not an Issue
On Hold
OS: Android
OS: Linux
OS: Linux (AltArch)
OS: Mac OS X
OS: Other
OS: Solaris / Illumos
OS: Windows
Parser
Performance
Places
Plugins
PR requested
PR: Draft - DO NOT MERGE
Printing
Privacy
Product Polish
Question
Redirected to Forum
Regression
Regression-window Wanted
Release Engineering
Release Uplift Wanted
Rendering
Research
Retarded
Security
Services
SessionStore
Stale
Standards Compliance
String Changes
Sync
The whole codebase
Theme
Theme Changes
UI
Unconfirmed
Verification Needed
Verified
Web Compatibility
WebGL/3D
Widget
Won't Fix
Works for me
Milestone
Set milestone
Clear milestone
No items
No Milestone
31.3.0
Assignees
Assign users
Clear assignees
No Assignees
Moonchild
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#457 Investigate and solve compiler warnings.
MoonchildProductions/UXP
Reference: MoonchildProductions/UXP#1999
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes