Missing functionality for RegExp.dotAll #2008

Closed
opened 9 months ago by Moonchild · 1 comments
Owner

Our implementation of RegExp dotAll doesn't seem to have all required functionality.
As reported in Topic 28836.

Preliminary analysis shows two problems:

  1. The s flag is parsed in strings /s but not when passed as separate flags in the Regex object CTOR. This seems to have been an oversight in my initial implementation.
  2. The RegExp.prototype.dotall property was finalized as dotAll with a capital A (to join the rest of the inconsistent casing of RegExp properties in the standard where some have camelCase and some do not). My implementation was dotall, therefore coming up with undefined property for .dotAll because of case sensitivity.

This shouldn't be too hard to fix.

See #1284 for the initial implementation. Funny how this has not been an issue for 3 whole years until it got reported.

Our implementation of RegExp dotAll doesn't seem to have all required functionality. As reported in [Topic 28836](https://forum.palemoon.org/viewtopic.php?f=70&t=28836). Preliminary analysis shows two problems: 1. The `s` flag is parsed in strings `/s` but not when passed as separate flags in the Regex object CTOR. This seems to have been an oversight in my initial implementation. 2. The RegExp.prototype.dotall property was finalized as `dotAll` with a capital A (to join the rest of the inconsistent casing of RegExp properties in the standard where some have camelCase and some do not). My implementation was `dotall`, therefore coming up with undefined property for `.dotAll` because of case sensitivity. This shouldn't be too hard to fix. See #1284 for the initial implementation. Funny how this has not been an issue for 3 whole years until it got reported.
Moonchild added this to the 31.3.0 milestone 9 months ago
Moonchild added the
Bug
Javascript
labels 9 months ago
Moonchild self-assigned this 9 months ago
Moonchild closed this issue 9 months ago
Poster
Owner

Verified manually in scratchpad for proper operation.

Verified manually in scratchpad for proper operation.
Moonchild added the
Fixed
Verified
labels 9 months ago
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: MoonchildProductions/UXP#2008
Loading…
There is no content yet.