#21 Remove Telemetry

Open
opened 4 years ago by wolfbeast · 15 comments
wolfbeast commented 4 years ago (Migrated from github.com)

This is going to be a big task, to be taken in small steps to not bust everything.

This is going to be a big task, to be taken in small steps to not bust everything.
JustOff commented 4 years ago (Migrated from github.com)
Owner

I accidentally found that Firefox Health Report service (FHR) is enabled for Pale Moon (while it isn’t for Basilisk), because MOZ_SERVICES_HEALTHREPORT=1 is set by default in old-configure.in. I’m not sure if any data are actually sent to Mozilla, but at least it is recorded in saved-telemetry-pings and datareporting folders in the profile.

I accidentally found that `Firefox Health Report` service ([FHR](https://wiki.mozilla.org/Firefox_Health_Report)) is enabled for `Pale Moon` (while it isn't for `Basilisk`), because `MOZ_SERVICES_HEALTHREPORT=1` is set by default in `old-configure.in`. I'm not sure if any data are actually sent to Mozilla, but at least it is recorded in `saved-telemetry-pings` and `datareporting` folders in the profile.
wolfbeast commented 4 years ago (Migrated from github.com)
Owner

Since there is no release of any kind of Pale Moon on UXP yet, what is your issue?

Since there is no release of any kind of Pale Moon on UXP yet, what is your issue?
mattatobin commented 4 years ago (Migrated from github.com)
Owner

Part of the first step to porting was to match configuration where possible to eliminate issues.. We know Mozilla has botched conditional status of platform components so working out those bits while trying to achieve basic buildablity work against each other.

Rest assured, this crap won’t stick around for long.

Part of the first step to porting was to match configuration where possible to eliminate issues.. We know Mozilla has botched conditional status of platform components so working out those bits while trying to achieve basic buildablity work against each other. Rest assured, this crap won't stick around for long.
wolfbeast commented 4 years ago (Migrated from github.com)
Owner

I’ve pushed a few conf changes in confvars so your precious data won’t be collected in a health report by default.

I've pushed a few conf changes in confvars so your precious data won't be collected in a health report by default.
JustOff commented 4 years ago (Migrated from github.com)
Owner

Thanks, this is exactly what I wanted to have until the telemetry is wiped off completely.

Thanks, this is exactly what I wanted to have until the telemetry is wiped off completely.
THEtomaso commented 4 years ago (Migrated from github.com)
Owner

I understand that this will involve a lot of work.
..but shouldn’t this issue be tagged for the 28.0.0 release milestone?
Many users will probably want to stay with Tycho, until it has been resolved.

I understand that this will involve a lot of work. ..but shouldn't this issue be tagged for the 28.0.0 release milestone? Many users will probably want to stay with Tycho, until it has been resolved.
wolfbeast commented 4 years ago (Migrated from github.com)
Owner

It’s not a release blocker. Telemetry is disabled -- actually removing it from the tree is something that will take time but is ultimately just code cleanup.

It's not a release blocker. Telemetry is disabled -- actually removing it from the tree is something that will take time but is ultimately just code cleanup.
JustOff commented 4 years ago (Migrated from github.com)
Owner

@THEtomaso, JFYI: Tycho also has Telemetry disabled, and not removed.

@THEtomaso, JFYI: Tycho also has Telemetry disabled, and not removed.
THEtomaso commented 4 years ago (Migrated from github.com)
Owner

Thanks for clarifying, guys. :)

Thanks for clarifying, guys. :)
THEtomaso commented 4 years ago (Migrated from github.com)
Owner

Another question though..
If it’s just a matter of code cleanup, why is this issue still labeled with “High Risk”, “Privacy” and “Security”?

Another question though.. If it's just a matter of code cleanup, why is this issue still labeled with "High Risk", "Privacy" and "Security"?
wolfbeast commented 4 years ago (Migrated from github.com)
Owner

The code removal is high risk because it is weaved into many things and can break functionality or impact security if not carefully removed. And it’s telemetry, so labeled with Privacy.

The code removal is high risk because it is weaved into many things and can break functionality or impact security if not carefully removed. And it's telemetry, so labeled with Privacy.
wolfbeast commented 3 years ago (Migrated from github.com)
Owner

Note to self: remove PaintTelemetry from /layout.

Note to self: remove PaintTelemetry from /layout.
Kokokokoka commented 3 years ago (Migrated from github.com)
Owner

There was #1074 which was closed. I would like to know, how could one fix this PR in order for it to be accepted?

There was #1074 which was closed. I would like to know, how could one fix this PR in order for it to be accepted?
adeshkp commented 3 years ago (Migrated from github.com)
Owner

@Kokokokoka By not doing everything in one single PR.
Do it step by step if interested, otherwise I’ll take care of it eventually (too busy at the moment).

@Kokokokoka By not doing everything in one single PR. Do it step by step if interested, otherwise I'll take care of it eventually (too busy at the moment).
mattatobin commented 3 years ago (Migrated from github.com)
Owner

It is getting very close to a defacto major stable release branch off point so hold off on this unless it is trivial.

It is getting very close to a defacto major stable release branch off point so hold off on this unless it is trivial.
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.