#445 Change the way the UX caption buttons are handled on Windows

Open
opened 2 years ago by wolfbeast · 4 comments
wolfbeast commented 2 years ago (Migrated from github.com)

Currently, the UX skin handles the caption buttons in different ways depending on OS.
For Windows 10, we’ve already had to implement our own buttons. For Windows Vista and 7, we have a decent solution cutting out the caption buttons and letting DWM handle it. On Windows 8, this still works but looks odd (especially with the 7/Vista cutout when using personas, since the Win 8 caption buttons are shaped differently).

A proper solution (with the only drawback being the “out of window glow” not being present on aero glass) would be to always draw our own buttons using XUL, and never use the DWM buttons. This avoids a good number of problems, not in the least issues where these buttons may come up black, being drawn with a delay, or not being drawn at all.

Once this is done, it’ll also become possible to move to always using active layers for accelerated layers which avoids more rendering quirks that are currently present.

Currently, the UX skin handles the caption buttons in different ways depending on OS. For Windows 10, we've already had to implement our own buttons. For Windows Vista and 7, we have a decent solution cutting out the caption buttons and letting DWM handle it. On Windows 8, this still works but looks odd (especially with the 7/Vista cutout when using personas, since the Win 8 caption buttons are shaped differently). A proper solution (with the only drawback being the "out of window glow" not being present on aero glass) would be to always draw our own buttons using XUL, and never use the DWM buttons. This avoids a good number of problems, not in the least issues where these buttons may come up black, being drawn with a delay, or not being drawn at all. Once this is done, it'll also become possible to move to always using active layers for accelerated layers which avoids more rendering quirks that are currently present.
wolfbeast commented 2 years ago (Migrated from github.com)
Owner
See also https://github.com/MoonchildProductions/Pale-Moon/issues/160
mattatobin commented 1 year ago (Migrated from github.com)
Owner

It’s been a year.. Are we gonna actually do this?

It's been a year.. Are we gonna actually do this?
wolfbeast commented 1 year ago (Migrated from github.com)
Owner

I still want this, yes.

I still want this, yes.
wolfbeast commented 1 year ago (Migrated from github.com)
Owner

After some testing with various assets, it’s clear this will never look decent on various flavors of Windows 7. It could still be done for Windows 8 with its simple caption controls, to remove the weird cut-out discrepancy there, but otherwise will remain as-is. Lowering priority accordingly.

After some testing with various assets, it's clear this will never look decent on various flavors of Windows 7. It could still be done for Windows 8 with its simple caption controls, to remove the weird cut-out discrepancy there, but otherwise will remain as-is. Lowering priority accordingly.
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.