MoonchildProductions
/
UXP
10
6
Fork 8
Code Issues 98 Pull Requests 0 Releases 87 Activity
Labels Milestones
New Issue

#981 Arrows style inconsistency on hover in Windows

Closed
opened 2 years ago by JustOff · 5 comments
JustOff commented 2 years ago (Migrated from github.com)

Both arrow-lft-hov.gif and arrow-rit-hov.gif are missing from the default Windows theme, although they are used in datetimepicker.css and arrow.css:

a219152bdd/toolkit/themes/windows/global/datetimepicker.css (L109-L115)

a219152bdd/toolkit/themes/windows/global/arrow.css (L34-L36)

a219152bdd/toolkit/themes/windows/global/arrow.css (L45-L47)

This results to visual glitches, as reported on the forum.

Both `arrow-lft-hov.gif` and `arrow-rit-hov.gif` are missing from the default Windows theme, although they are used in `datetimepicker.css` and `arrow.css`: https://github.com/MoonchildProductions/UXP/blob/a219152bddead6b34f40ae86217f39fbda91aab6/toolkit/themes/windows/global/datetimepicker.css#L109-L115 https://github.com/MoonchildProductions/UXP/blob/a219152bddead6b34f40ae86217f39fbda91aab6/toolkit/themes/windows/global/arrow.css#L34-L36 https://github.com/MoonchildProductions/UXP/blob/a219152bddead6b34f40ae86217f39fbda91aab6/toolkit/themes/windows/global/arrow.css#L45-L47 This results to visual glitches, as [reported on the forum](https://forum.palemoon.org/viewtopic.php?f=3&t=21543).
wolfbeast commented 2 years ago (Migrated from github.com)
Owner

Pulling discussion to the issue instead of the PR
https://github.com/MoonchildProductions/UXP/pull/982#issuecomment-469004351

Pulling discussion to the issue instead of the PR https://github.com/MoonchildProductions/UXP/pull/982#issuecomment-469004351
wolfbeast commented 2 years ago (Migrated from github.com)
Owner

Just because the situation of mapping normal and hover to the same image existed for a long time doesn’t make it right.

Let’s improve what we have and make actually -different- images for the hover state (e.g. brightness, glow or other common hover effect) to provide the user with immediate feedback (Improve intuitive responsiveness of the UI)

Just because the situation of mapping normal and hover to the same image existed for a long time doesn't make it right. Let's improve what we have and make actually -different- images for the hover state (e.g. brightness, glow or other common hover effect) to provide the user with immediate feedback (Improve intuitive responsiveness of the UI)
JustOff commented 2 years ago (Migrated from github.com)
Owner

Sorry, but in this case, I have to step aside, because I don’t have the necessary graphic design skills.

Sorry, but in this case, I have to step aside, because I don't have the necessary graphic design skills.
wolfbeast commented 2 years ago (Migrated from github.com)
Owner

LOL. Okay I guess using a paint program is too difficult.

LOL. Okay I guess using a paint program is too difficult.
JustOff commented 2 years ago (Migrated from github.com)
Owner

Your assumption is wrong, but whatever. Good there is someone to do it properly 👍

Your assumption is wrong, but whatever. Good there is someone to do it **properly** :+1:
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Apply labels
Clear labels
App: All App: Basilisk App: Borealis App: Fennec App: IceApe App: IceDove App: IceWeasel App: Interlink App: Pale Moon App: Toolkit Assigned Backed Out Bitrotted Bounty
This issue is eligible for payment of a bounty. Bounty paid
Bounty issue fully completed and paid. Bug Build Bustage C: Add-ons Manager C: Build System C: DevTools C: DOM C: Editor
HTML editor and editable HTML elements C: Extensions C: Images
Image codecs and image handling C: Installer/Updater C: Javascript C: Layout C: Layout - CSS C: MailNews Core
MailNews, Mork, and LDAP C: Media C: Media - EME C: Media - WebRTC C: Memory C: Networking C: Parser
Dealing with the XML/HTML parser C: Places
Bookmarks/History/Library C: Plugins C: Printing C: Rendering C: SessionStore C: Sync C: Theme C: UI C: WebExAM
The WebExtensions enabled Add-ons Manager C: Widget Code Cleanup Crash Critical Debug: Build
Debug Build Issues Debug: Runtime
Debug Runtime Issues dependencies
Pull requests that update a dependency file Done
Like fixed but merely done Duplicate Enhancement Everybody Wins!
For those really rare occasions where everyone agrees in the end. Fixed Good Enough Good first issue
Good issue for contributers new to the project. Hang High Priority High Risk Incomplete Invalid Leave open Legal Localization Low Priority Low Risk Meta-issue More info needed Mozregression Wanted
Regression window or fix window wanted on mozilla-central with mozregression. Not an Issue On Hold OS: Android OS: Linux OS: Linux (AltArch)
Linux on other architectures such as ARM and PPC OS: Mac OS X OS: Other OS: Solaris / Illumos OS: Windows Performance PR requested
Issue with code work but no PR. PR: Draft - DO NOT MERGE Privacy Product Polish Question Redirected to Forum Regression Release Engineering Research Retarded
Do not use this label Review: r+ Review: r- Review: r? Security Services
Related to services provided for applications. Stale Standards Compliance String Changes Super Critical II Turbo Revival The whole codebase
Affects many components Theme Changes Unconfirmed Verification Needed Verified Wanted: Release Uplift Web Compatibility WebGL/3D
Related to WebGL(2) and 3D object rendering code. Won't Fix Works for me
No Label
App: All
App: Basilisk
App: Borealis
App: Fennec
App: IceApe
App: IceDove
App: IceWeasel
App: Interlink
App: Pale Moon
App: Toolkit
Assigned
Backed Out
Bitrotted
Bounty
Bounty paid
Bug
Build Bustage
C: Add-ons Manager
C: Build System
C: DevTools
C: DOM
C: Editor
C: Extensions
C: Images
C: Installer/Updater
C: Javascript
C: Layout
C: Layout - CSS
C: MailNews Core
C: Media
C: Media - EME
C: Media - WebRTC
C: Memory
C: Networking
C: Parser
C: Places
C: Plugins
C: Printing
C: Rendering
C: SessionStore
C: Sync
C: Theme
C: UI
C: WebExAM
C: Widget
Code Cleanup
Crash
Critical
Debug: Build
Debug: Runtime
dependencies
Done
Duplicate
Enhancement
Everybody Wins!
Fixed
Good Enough
Good first issue
Hang
High Priority
High Risk
Incomplete
Invalid
Leave open
Legal
Localization
Low Priority
Low Risk
Meta-issue
More info needed
Mozregression Wanted
Not an Issue
On Hold
OS: Android
OS: Linux
OS: Linux (AltArch)
OS: Mac OS X
OS: Other
OS: Solaris / Illumos
OS: Windows
Performance
PR requested
PR: Draft - DO NOT MERGE
Privacy
Product Polish
Question
Redirected to Forum
Regression
Release Engineering
Research
Retarded
Review: r+
Review: r-
Review: r?
Security
Services
Stale
Standards Compliance
String Changes
Super Critical II Turbo Revival
The whole codebase
Theme Changes
Unconfirmed
Verification Needed
Verified
Wanted: Release Uplift
Web Compatibility
WebGL/3D
Won't Fix
Works for me
Milestone
Set milestone
Clear milestone
No items
No Milestone
28.5.0
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes