#1806 Update libcubeb to latest version

Open
opened 3 months ago by Moonchild · 5 comments

We’re currently using a manually-patched libcubeb that’s older. We should update this external lib and fix callers for API changes to pick up upstream improvements and bugfixes.

We're currently using a manually-patched libcubeb that's older. We should update this external lib and fix callers for API changes to pick up upstream improvements and bugfixes.
Moonchild added the
High Priority
label 3 months ago
Moonchild self-assigned this 3 months ago
Moonchild added the
Wanted: Release Uplift
label 3 months ago
Moonchild added this to the (deleted) milestone 3 months ago
Moonchild added this to the 29.4.0 milestone 3 months ago

Verified in SunOS. Thanks Athenian!

Verified in SunOS. Thanks Athenian!
Moonchild closed this issue 3 months ago

Due to unexpected sound issues for a number of people that can’t quickly be solved, as well as potential impact for WebRTC handling, the work here has been backed out from release.
Work will continue to solve these issues on a work branch parallel to master that will be used to build ustable channel builds until resolved, after which that channel will go back to master and a manual landing will take place.

Due to unexpected sound issues for a number of people that can't quickly be solved, as well as potential impact for WebRTC handling, the work here has been backed out from release. Work will continue to solve these issues on a work branch parallel to `master` that will be used to build ustable channel builds until resolved, after which that channel will go back to `master` and a manual landing will take place.
Moonchild reopened this issue 3 months ago
Moonchild removed the
Wanted: Release Uplift
label 3 months ago
Moonchild added the
High Risk
label 3 months ago
Moonchild removed this from the 29.4.0 milestone 3 months ago
Moonchild removed the
High Priority
label 3 months ago

Dropping priority to normal; our previous cubeb implementation is not an issue for the short-medium term.

Dropping priority to normal; our previous cubeb implementation is not an issue for the short-medium term.

@athenian200 sorry for not being very active on this one at the moment. I’ll look at the PR this weekend, make a few builds and tests and if it looks good I’ll merge it into master and shove new unstables out.

@athenian200 sorry for not being very active on this one at the moment. I'll look at the PR this weekend, make a few builds and tests and if it looks good I'll merge it into master and shove new unstables out.
athenian200 was assigned by Moonchild 3 months ago

Yeah. I went ahead and redid the branch, because the initial one that got audio working on Windows basically had one huge commit and two follow-ups because I forgot to make commits as I was working at first.

The new branch has a lot more commits because I tried to break my work apart into smaller chunks initially so it’s easier to understand what I did, but it wound up with a ton of silly follow-up commits where I did things like had to change DOS line endings into Unix ones because I created a new file on Windows when redoing the branch, reapplied the SunOS and Linux patch to restore that functionality, etc. I should probably squash those commits into the main work.

But now it does exactly the same thing as the original branch and describes things more clearly, I think.

Yeah. I went ahead and redid the branch, because the initial one that got audio working on Windows basically had one huge commit and two follow-ups because I forgot to make commits as I was working at first. The new branch has a lot more commits because I tried to break my work apart into smaller chunks initially so it's easier to understand what I did, but it wound up with a ton of silly follow-up commits where I did things like had to change DOS line endings into Unix ones because I created a new file on Windows when redoing the branch, reapplied the SunOS and Linux patch to restore that functionality, etc. I should probably squash those commits into the main work. But now it does exactly the same thing as the original branch and describes things more clearly, I think.
This repo is archived. You cannot comment on issues.
No Milestone
No Assignees
2 Participants
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.