#61 Reinstate GKMEDIAS_SHARED_LIBRARY

Open
opened 3 years ago by mattatobin · 7 comments
mattatobin commented 3 years ago (Migrated from github.com)

- Disabled at **Mozilla** by https://bugzilla.mozilla.org/show_bug.cgi?id=922912 - Reverted and fixed in **Tycho** by https://repo.palemoon.org/MoonchildProductions/Pale-Moon/commit/1f0c715b4de14e9847cb4d6e44d1a32c7a08fcca - Apparently busted badly at **Mozilla** by https://bugzilla.mozilla.org/show_bug.cgi?id=1051146 - And completely removed at **Mozilla** by https://bugzilla.mozilla.org/show_bug.cgi?id=1216444 ---- - [x] Restore Configure Flags - [x] Restore mozbuild logic - [x] Restore symbols.def.in and update it
mattatobin commented 1 year ago (Migrated from github.com)

Blocks #1451

Blocks #1451
Moonchild commented 1 year ago

pocketsphinx was already killed by me earlier because it’s a lib we don’t need, so the “busting” part of this should no longer be present in our tree.
I’m having a poke at this to see if I can get it building as a shared lib on Windows again.

`pocketsphinx` was already killed by me earlier because it's a lib we don't need, so the "busting" part of this should no longer be present in our tree. I'm having a poke at this to see if I can get it building as a shared lib on Windows again.
Moonchild commented 1 year ago

The commit above fully restores split out gkmedias in a --disable-skia state
Skia is being a pain by throwing unresolved externals when linking gkmedias.dll that i wasn’t able to quickly solve so i opted for focusing on building without Skia first, which now works with the provided patch. Packaging needs some FE addition to grab the additional dll of course, but that’s trivial.

The commit above fully restores split out gkmedias in a `--disable-skia` state Skia is being a pain by throwing unresolved externals when linking gkmedias.dll that i wasn't able to quickly solve so i opted for focusing on building without Skia first, which now works with the provided patch. Packaging needs some FE addition to grab the additional dll of course, but that's trivial.
Moonchild commented 1 year ago

I’ve restored the mozbuild logic and symbols file (and updated it for changes in Brotli, adding aom for AV1, etc.)
This currently selects a split dll for Windows automatically (like it did before). I don’t think this was ever done on Linux but not sure.

@mattatobin which configure flags would you like to see restored, exactly? something to control GKMEDIAS_SHARED_LIBRARY on any platform, or...?

I've restored the mozbuild logic and symbols file (and updated it for changes in Brotli, adding aom for AV1, etc.) This currently selects a split dll for Windows automatically (like it did before). I don't think this was ever done on Linux but not sure. @mattatobin which configure flags would you like to see restored, exactly? something to control `GKMEDIAS_SHARED_LIBRARY` on any platform, or...?

It never had a configure flag but was selected based on target os which we should restore but a --enable-shared-media wouldn’t be inconsistant because ideally we would like it to work on those as well eventually.

If you want me to do that part I can.

It never had a configure flag but was selected based on target os which we should restore but a --enable-shared-media wouldn't be inconsistant because ideally we would like it to work on those as well eventually. If you want me to do that part I can.
Moonchild commented 1 year ago

If you feel like it, sure -- otherwise I’ll do it myself tomorrow.

If you feel like it, sure -- otherwise I'll do it myself tomorrow.
mattatobin removed the
Research
label 1 year ago
Moonchild was assigned by mattatobin 1 year ago
mattatobin self-assigned this 1 year ago
Moonchild added the
App: All
label 1 year ago

Ping @Ascrod

Ping @Ascrod
mattatobin added the
OS: Windows
label 1 year ago
mattatobin added the
Fixed
label 1 year ago
mattatobin added the
Wanted: Release Uplift
label 1 year ago
mattatobin removed the
App: All
label 1 year ago
This repo is archived. You cannot comment on issues.
No Milestone
No Assignees
2 Participants
Due Date

No due date set.

Loading…
There is no content yet.